Re: [PATCH v2 02/13] spi: Replace all spi->chip_select and spi->cs_gpiod references with function call
From: Dhruva Gole <hidden>
Date: 2023-01-23 14:24:12
Also in:
dri-devel, linux-amlogic, linux-arm-msm, linux-aspeed, linux-iio, linux-media, linux-mediatek, linux-riscv, linux-samsung-soc, linux-spi, linux-staging, linux-sunxi, linux-tegra, linux-wireless, lkml
Hi Amit, On 20/01/23 00:23, Amit Kumar Mahapatra wrote:
Supporting multi-cs in spi drivers would require the chip_select & cs_gpiod members of struct spi_device to be an array. But changing the type of these members to array would break the spi driver functionality. To make the transition smoother introduced four new APIs to get/set the spi->chip_select & spi->cs_gpiod and replaced all spi->chip_select and spi->cs_gpiod references with get or set API calls. While adding multi-cs support in further patches the chip_select & cs_gpiod members of the spi_device structure would be converted to arrays & the "idx" parameter of the APIs would be used as array index i.e., spi->chip_select[idx] & spi->cs_gpiod[idx] respectively. Signed-off-by: Amit Kumar Mahapatra <redacted> --- [...] drivers/spi/spi-cadence-quadspi.c | 5 +++-- drivers/spi/spi-cadence-xspi.c | 4 ++-- drivers/spi/spi-cadence.c | 4 ++--
[...] For SPI Cadence QSPI, Reviewed-by: Dhruva Gole <redacted> -- Best regards, Dhruva Gole Texas Instruments Incorporated