Thread (30 messages) 30 messages, 7 authors, 2023-01-23

Re: [PATCH v2 04/11] dt-bindings: watchdog: convert meson-wdt.txt to dt-schema

From: Neil Armstrong <neil.armstrong@linaro.org>
Date: 2023-01-23 09:42:28
Also in: linux-amlogic, linux-arm-kernel, linux-devicetree, linux-media, linux-mmc, linux-pci, linux-phy, linux-rtc, linux-watchdog, lkml

On 10/01/2023 22:48, Martin Blumenstingl wrote:
Hi Neil,

On Mon, Jan 9, 2023 at 1:53 PM Neil Armstrong [off-list ref] wrote:
[...]
quoted
+  compatible:
+    oneOf:
+      - enum:
+          - amlogic,meson6-wdt
+          - amlogic,meson8-wdt
Technically this is not an identical representation of what we had
before which was:
-       "amlogic,meson8-wdt" and "amlogic,meson6-wdt" on Meson8 SoCs

We're not using the "amlogic,meson8-wdt" compatible anywhere at the moment.
In the meson_wdt driver it's defined with the same per-SoC data as
"amlogic,meson6-wdt".

Long story short: In my opinion there's no need to change what you
have right now.
If you have to re-spin this then maybe you can add a note to the patch
description.
Please add my:
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Sorry I was distracted, I'll add a node on the commit message.

Thanks,
Neil

Best regards,
Martin
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help