Re: [PATCH v4 6/7] riscv: dts: starfive: jh7110: Add ethernet device node
From: Krzysztof Kozlowski <hidden>
Date: 2023-01-18 15:56:19
Also in:
linux-devicetree, linux-riscv, lkml
On 18/01/2023 07:17, Yanhong Wang wrote:
quoted hunk ↗ jump to hunk
Add JH7110 ethernet device node to support gmac driver for the JH7110 RISC-V SoC. Signed-off-by: Yanhong Wang <redacted> --- arch/riscv/boot/dts/starfive/jh7110.dtsi | 93 ++++++++++++++++++++++++ 1 file changed, 93 insertions(+)diff --git a/arch/riscv/boot/dts/starfive/jh7110.dtsi b/arch/riscv/boot/dts/starfive/jh7110.dtsi index c22e8f1d2640..c6de6e3b1a25 100644 --- a/arch/riscv/boot/dts/starfive/jh7110.dtsi +++ b/arch/riscv/boot/dts/starfive/jh7110.dtsi@@ -433,5 +433,98 @@ reg-shift = <2>; status = "disabled"; }; + + stmmac_axi_setup: stmmac-axi-config {
Why your bindings example is different? Were the bindings tested? Ahh, no they were not... Can you send only tested patches? Was this tested?
+ snps,lpi_en; + snps,wr_osr_lmt = <4>; + snps,rd_osr_lmt = <4>; + snps,blen = <256 128 64 32 0 0 0>; + }; +
Best regards, Krzysztof