Re: [PATCH v1] wireless/at76c50x-usb.c : Use devm_kzalloc replaces kmalloc
From: Kalle Valo <kvalo@kernel.org>
Date: 2023-01-16 06:33:53
Also in:
linux-wireless, lkml
Eric Dumazet [off-list ref] writes:
On Fri, Jan 13, 2023 at 2:35 PM Lizhe [off-list ref] wrote:quoted
use devm_kzalloc replaces kamlloc Signed-off-by: Lizhe <redacted> --- drivers/net/wireless/atmel/at76c50x-usb.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)diff --git a/drivers/net/wireless/atmel/at76c50x-usb.c b/drivers/net/wireless/atmel/at76c50x-usb.c index 009bca34ece3..ebd8ef525557 100644 --- a/drivers/net/wireless/atmel/at76c50x-usb.c +++ b/drivers/net/wireless/atmel/at76c50x-usb.c@@ -2444,7 +2444,7 @@ static int at76_probe(struct usb_interface *interface, udev = usb_get_dev(interface_to_usbdev(interface)); - fwv = kmalloc(sizeof(*fwv), GFP_KERNEL); + fwv = devm_kzalloc(sizeof(*fwv), GFP_KERNEL);Have you compiled this patch ?
Clearly not: https://lore.kernel.org/linux-wireless/202301140533.jMlST9Ur-lkp@intel.com/ (local) Lizhe, do not EVER submit untested patches. In some simple patches doing just a compilation test might suffice, but please mention the patch is only compile tested clearly in the commit log. But not even doing a compilation test is a big no. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches