On Fri, Jan 13, 2023 at 09:46:49AM +0200, Laurent Pinchart wrote:

Hi Christoph,

Thank you for the patch.

On Fri, Jan 13, 2023 at 07:23:18AM +0100, Christoph Hellwig wrote:

quoted

This driver depends on ARM && ARCH_SHMOBILE, but ARCH_SHMOBILE can only be
set for each/sh, making the driver dead code except for the COMPILE_TEST
case.

Signed-off-by: Christoph Hellwig <hch@lst.de>

No objection from me.

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

To expand a little bit on this, ARCH_SHMOBILE used to be set for the
ARM-based shmobile SoCs too, until

commit 08e735233ea29b17bfec8e4cb302e799d9f920b8
Author: Geert Uytterhoeven [off-list ref]
Date:   Tue Aug 28 17:10:10 2018 +0200

    ARM: shmobile: Remove the ARCH_SHMOBILE Kconfig symbol

    All drivers for Renesas ARM SoCs have gained proper ARCH_RENESAS
    platform dependencies.  Hence finish the conversion from ARCH_SHMOBILE
    to ARCH_RENESAS for Renesas 32-bit ARM SoCs, as started by commit
    9b5ba0df4ea4f940 ("ARM: shmobile: Introduce ARCH_RENESAS").

    Signed-off-by: Geert Uytterhoeven [off-list ref]
    Acked-by: Arnd Bergmann [off-list ref]
    Signed-off-by: Simon Horman [off-list ref]

merged in v4.20. The DRM shmobile driver's Kconfig entry wasn't updated,
making it dead code indeed.

I haven't tested this driver in ages, hence my lack of objection, but
someone may want to keep it for the pre-R-Car ARM SoCs.

Also, I just noticed that you forgot to update the MAINTAINERS file in
this patch to drop the drivers/gpu/drm/shmobile/ entry.

quoted

---
 drivers/gpu/drm/Kconfig                       |   2 -
 drivers/gpu/drm/Makefile                      |   1 -
 drivers/gpu/drm/shmobile/Kconfig              |  12 -
 drivers/gpu/drm/shmobile/Makefile             |   8 -
 .../gpu/drm/shmobile/shmob_drm_backlight.c    |  82 ---
 .../gpu/drm/shmobile/shmob_drm_backlight.h    |  19 -
 drivers/gpu/drm/shmobile/shmob_drm_crtc.c     | 683 ------------------
 drivers/gpu/drm/shmobile/shmob_drm_crtc.h     |  55 --
 drivers/gpu/drm/shmobile/shmob_drm_drv.c      | 303 --------
 drivers/gpu/drm/shmobile/shmob_drm_drv.h      |  42 --
 drivers/gpu/drm/shmobile/shmob_drm_kms.c      | 150 ----
 drivers/gpu/drm/shmobile/shmob_drm_kms.h      |  29 -
 drivers/gpu/drm/shmobile/shmob_drm_plane.c    | 261 -------
 drivers/gpu/drm/shmobile/shmob_drm_plane.h    |  19 -
 drivers/gpu/drm/shmobile/shmob_drm_regs.h     | 310 --------
 15 files changed, 1976 deletions(-)
 delete mode 100644 drivers/gpu/drm/shmobile/Kconfig
 delete mode 100644 drivers/gpu/drm/shmobile/Makefile
 delete mode 100644 drivers/gpu/drm/shmobile/shmob_drm_backlight.c
 delete mode 100644 drivers/gpu/drm/shmobile/shmob_drm_backlight.h
 delete mode 100644 drivers/gpu/drm/shmobile/shmob_drm_crtc.c
 delete mode 100644 drivers/gpu/drm/shmobile/shmob_drm_crtc.h
 delete mode 100644 drivers/gpu/drm/shmobile/shmob_drm_drv.c
 delete mode 100644 drivers/gpu/drm/shmobile/shmob_drm_drv.h
 delete mode 100644 drivers/gpu/drm/shmobile/shmob_drm_kms.c
 delete mode 100644 drivers/gpu/drm/shmobile/shmob_drm_kms.h
 delete mode 100644 drivers/gpu/drm/shmobile/shmob_drm_plane.c
 delete mode 100644 drivers/gpu/drm/shmobile/shmob_drm_plane.h
 delete mode 100644 drivers/gpu/drm/shmobile/shmob_drm_regs.h

-- 
Regards,

Laurent Pinchart