Re: [PATCH net-next 03/10] net: mdio: mux-bcm-iproc: Separate C22 and C45 transactions

From
Florian Fainelli <f.fainelli@gmail.com>
Date
2023-01-12 21:32:11
Also in
linux-arm-kernel, linux-aspeed, linux-mediatek, linuxppc-dev, lkml
Reply to
Michael Walle, 2023-01-12
On 1/12/23 07:15, Michael Walle wrote:
From: Andrew Lunn <andrew@lunn.ch>

The MDIO mux broadcom iproc can perform both C22 and C45 transfers.
Create separate functions for each and register the C45 versions using
the new API calls.

Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Michael Walle <redacted>
---
Apparently, in the c45 case, the reg value including the MII_ADDR_C45
bit is written to the hardware. Looks weird, that a "random" software
bit is written to a register. Florian is that correct? Also, with this
patch this flag isn't set anymore.
We should be masking the MII_ADDR_C45 bit because the MDIO_ADDR_OFFSET only defines bits 0 through 20 as being read/write and bits above being read-only. In practice, this is probably not making any difference or harm.
-- 
Florian
Thread (13 messages) 13 messages, 3 authors, last reply 2023-01-14
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help