Re: [PATCH net-next 1/5] net/ethtool: add netlink interface for the PLCA RS

On Thu, Jan 05, 2023 at 11:47:20AM +0100, Piergiorgio Beruto wrote:

Thanks Leon for your review.
Please, see my comments below.

<...>

quoted

quoted

+	ret = ethnl_ops_begin(dev);
+	if (ret < 0)
+		goto out;

I see that many places in the code used this ret > 0 check, but it looks
like the right check is if (ret).

Thanks. I've fixed those, although I copied this code from similar files
(like cable test). Maybe we should check these out as well?

I don't think that it is worth to invest time in that. The code works
the same with if (ret<0) and if(!ret).

Thanks

quoted

Thanks

Thanks!
Piergiorgio