On Tue, Jan 03, 2023 at 11:54:24AM +0200, Leon Romanovsky wrote:

On Sun, Jan 01, 2023 at 11:34:21AM +0100, Paul Menzel wrote:

quoted

Am 01.01.23 um 09:32 schrieb Leon Romanovsky:

quoted

On Thu, Dec 29, 2022 at 05:56:40PM +0530, Rajat Khandelwal wrote:

quoted

The CPU logs get flooded with replay rollover/timeout AER errors in
the system with i225_lmvp connected, usually inside thunderbolt devices.

One of the prominent TBT4 docks we use is HP G4 Hook2, which incorporates
an Intel Foxville chipset, which uses the igc driver.
On connecting ethernet, CPU logs get inundated with these errors. The point
is we shouldn't be spamming the logs with such correctible errors as it
confuses other kernel developers less familiar with PCI errors, support
staff, and users who happen to look at the logs.

quoted

quoted

quoted

--- a/drivers/net/ethernet/intel/igc/igc_main.c
+++ b/drivers/net/ethernet/intel/igc/igc_main.c

quoted

quoted

quoted

+static void igc_mask_aer_replay_correctible(struct igc_adapter *adapter)

quoted

quoted

Shouldn't this igc_mask_aer_replay_correctible function be implemented
in drivers/pci/quirks.c and not in igc_probe()?

Probably. Though I think, the PCI quirk file, is getting too big.

As long as that file is right location, we should use it.
One can refactor quirk file later.

If a quirk like this is only needed when the driver is loaded, I think
the driver is a better place than drivers/pci/quirks.c.  If it's in
quirks.c, either we have to replicate driver Kconfig via #ifdefs, or
the kernel contains the quirk for systems that don't need it.

I'm generally not a fan of simply masking errors because they're
annoying.  I'd prefer to figure out the root cause and fix it if
possible.  Or maybe we can tone down or rate-limit the logging so it's
not so alarming.

Bjorn