On Fri, Jan 27, 2023 at 12:32:21PM +0100, Simon Horman wrote:
On Thu, Jan 26, 2023 at 08:58:35AM +0100, Jiri Pirko wrote:
quoted
From: Jiri Pirko <redacted>
Commit 1d18bb1a4ddd ("devlink: allow registering parameters after
the instance") as the subject implies introduced possibility to register
devlink params even for already registered devlink instance. This is a
bit problematic, as the consistency or params list was originally
secured by the fact it is static during devlink lifetime. So in order to
protect the params list, take devlink instance lock during the params
operations. Introduce unlocked function variants and use them in drivers
in locked context. Put lock assertions to appropriate places.
Signed-off-by: Jiri Pirko <redacted>
Reviewed-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
---
drivers/net/ethernet/mellanox/mlx4/main.c | 80 ++++++++--------
drivers/net/ethernet/mellanox/mlx5/core/dev.c | 18 ++--
.../net/ethernet/mellanox/mlx5/core/devlink.c | 92 +++++++++----------
drivers/net/ethernet/mellanox/mlx5/core/eq.c | 12 +--
.../net/ethernet/mellanox/mlx5/core/eswitch.c | 6 +-
.../net/ethernet/mellanox/mlx5/core/main.c | 12 +--
drivers/net/ethernet/mellanox/mlxsw/core.c | 18 ++--
.../net/ethernet/mellanox/mlxsw/spectrum.c | 16 ++--
.../ethernet/netronome/nfp/devlink_param.c | 8 +-
.../net/ethernet/netronome/nfp/nfp_net_main.c | 7 +-
drivers/net/netdevsim/dev.c | 36 ++++----
include/net/devlink.h | 16 +++-
net/devlink/leftover.c | 77 +++++++++++-----
13 files changed, 218 insertions(+), 180 deletions(-)
For the nfp portion:
Reviewed-by: Simon Horman <redacted>
I will also see about getting the patchset tested on NFP hardware.
Seems the team was a bit further ahead on the testing than I thought.
So, on their behalf:
Tested-by: Simon Horman <redacted>