Re: [PATCH net-next 1/7] sfc: add devlink support for ef100

On 20/01/2023 14:11, Lucero Palau, Alejandro wrote:

On 1/19/23 23:40, Jacob Keller wrote:

quoted

On 1/19/2023 3:31 AM, alejandro.lucero-palau@amd.com wrote:

quoted

@@ -1124,6 +1125,10 @@ int ef100_probe_netdev_pf(struct efx_nic *efx)
  		netif_warn(efx, probe, net_dev,
  			   "Failed to probe base mport rc %d; representors will not function\n",
  			   rc);
+	} else {
+		if (efx_probe_devlink(efx))
+			netif_warn(efx, probe, net_dev,
+				   "Failed to register devlink\n");
  	}
  

A bit of a weird construction here with the next step in an else block?
I guess this is being treated as an optional feature, and depends on
efx_ef100_get_base_mport succeeding?

Right. The mae ports initialization can fail but the driver can still 
initialize the device with limited functionality.

But in that case, we probably should support e.g. devlink info, even
 though without the MAE ports we can't support devlink port.