Re: [PATCH net-next v2 3/7] netfilter: flowtable: allow unidirectional rules

On Tue 17 Jan 2023 at 12:15, Marcelo Ricardo Leitner [off-list ref] wrote:

On Fri, Jan 13, 2023 at 05:55:44PM +0100, Vlad Buslov wrote:

quoted

Modify flow table offload to support unidirectional connections by
extending enum nf_flow_flags with new "NF_FLOW_HW_BIDIRECTIONAL" flag. Only
offload reply direction when the flag is not set. This infrastructure

                                           ^^^ s///, I believe? :-)

Good catch!

...

quoted

-	ok_count += flow_offload_tuple_add(offload, flow_rule[1],
-					   FLOW_OFFLOAD_DIR_REPLY);
+	if (test_bit(NF_FLOW_HW_BIDIRECTIONAL, &offload->flow->flags))
+		ok_count += flow_offload_tuple_add(offload, flow_rule[1],
+						   FLOW_OFFLOAD_DIR_REPLY);
 	if (ok_count == 0)