Re: [PATCH net-next v4 03/10] tsnep: Do not print DMA mapping error
From: Gerhard Engleder <hidden>
Date: 2023-01-10 19:47:52
On 10.01.23 16:53, Alexander H Duyck wrote:
On Mon, 2023-01-09 at 20:15 +0100, Gerhard Engleder wrote:quoted
Printing in data path shall be avoided. DMA mapping error is already counted in stats so printing is not necessary. Signed-off-by: Gerhard Engleder <redacted> --- drivers/net/ethernet/engleder/tsnep_main.c | 2 -- 1 file changed, 2 deletions(-)diff --git a/drivers/net/ethernet/engleder/tsnep_main.c b/drivers/net/ethernet/engleder/tsnep_main.c index d148ba422b8c..8c6d6e210494 100644 --- a/drivers/net/ethernet/engleder/tsnep_main.c +++ b/drivers/net/ethernet/engleder/tsnep_main.c@@ -469,8 +469,6 @@ static netdev_tx_t tsnep_xmit_frame_ring(struct sk_buff *skb, spin_unlock_bh(&tx->lock); - netdev_err(tx->adapter->netdev, "TX DMA map failed\n"); - return NETDEV_TX_OK; } length = retval;It might be nice to add a stat to indicate that this is specifically a mapping error rather than just incrementing dropped but that could also be done in a future patch.
I took a note for future work. Gerhard