On Mon, Jan 09, 2023 at 06:07:45PM +0000, Mogilappagari, Sudheer wrote:

quoted

-----Original Message-----
From: Jakub Kicinski <kuba@kernel.org>
Sent: Friday, January 6, 2023 1:42 PM
To: Mogilappagari, Sudheer <redacted>
Cc: netdev@vger.kernel.org; mkubecek@suse.cz; andrew@lunn.ch;
Samudrala, Sridhar [off-list ref]; Nguyen, Anthony L
[off-list ref]
Subject: Re: [PATCH ethtool-next v4 2/2] netlink: add netlink handler
for get rss (-x)

[...]

quoted

No no, look how the strings for hfunc names are fetched - they are
fetched over a different socket, right?

global_stringset is using nlctx->ethnl2_socket. Are you suggesting use
of it for fetching channels info too ? 

ret = netlink_init_ethnl2_socket(nlctx);
...
hash_funcs = global_stringset(ETH_SS_RSS_HASH_FUNCS, nlctx->ethnl2_socket);

The purpose of the second socket is to allow sending another request
while we are still processing the data from the main request so that we
cannot reuse the primary socket.

In this case, if we do not support dumps (and do not intend to), we
could technically send both request through the same socket (one after
the other) but I think it would be easier to use ethnl2_socket for the
auxiliary request anyway.

Michal