RE: [Intel-wired-lan] [PATCH net] ice: Fix potential memory leak in ice_gnss_tty_write()

-----Original Message-----
From: Intel-wired-lan <mailto:intel-wired-lan-bounces@osuosl.org> On Behalf Of Yuan Can
Sent: Wednesday, December 7, 2022 12:55 AM
To: Brandeburg, Jesse <mailto:jesse.brandeburg@intel.com>; Nguyen, Anthony L <mailto:anthony.l.nguyen@intel.com>; mailto:davem@davemloft.net; mailto:edumazet@google.com; mailto:kuba@kernel.org; mailto:pabeni@redhat.com; Kolacinski, Karol <mailto:karol.kolacinski@intel.com>; mailto:intel-wired-lan@lists.osuosl.org; mailto:netdev@vger.kernel.org
Cc: mailto:yuancan@huawei.com
Subject: [Intel-wired-lan] [PATCH net] ice: Fix potential memory leak in ice_gnss_tty_write()

The ice_gnss_tty_write() return directly if the write_buf alloc failed, leaking the cmd_buf.

Fix by free cmd_buf if write_buf alloc failed.

Fixes: d6b98c8d242a ("ice: add write functionality for GNSS TTY")
Signed-off-by: Yuan Can <mailto:yuancan@huawei.com>
---
drivers/net/ethernet/intel/ice/ice_gnss.c | 1 +
1 file changed, 1 insertion(+)

Tested-by:  Vasanth Stany < mailto:vasanth.stany.v@intel.com >