[PATCH net-next v1 4/4] net: phy: mxl-gpy: disable interrupts on GPY215 by default
From: Michael Walle <hidden>
Date: 2022-12-02 15:12:33
Also in:
linux-devicetree, lkml
Subsystem:
ethernet phy library, maxlinear ethernet phy driver, networking drivers, the rest · Maintainers:
Andrew Lunn, Heiner Kallweit, Xu Liang, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds
The interrupts on the GPY215B and GPY215C are broken and the only viable fix is to disable them altogether. There is still the possibilty to opt-in via the device tree. Signed-off-by: Michael Walle <redacted> --- drivers/net/phy/mxl-gpy.c | 5 +++++ 1 file changed, 5 insertions(+)
diff --git a/drivers/net/phy/mxl-gpy.c b/drivers/net/phy/mxl-gpy.c
index 20e610dda891..edb8cd8313b0 100644
--- a/drivers/net/phy/mxl-gpy.c
+++ b/drivers/net/phy/mxl-gpy.c@@ -12,6 +12,7 @@ #include <linux/mutex.h> #include <linux/phy.h> #include <linux/polynomial.h> +#include <linux/property.h> #include <linux/netdevice.h> /* PHY ID */
@@ -290,6 +291,10 @@ static int gpy_probe(struct phy_device *phydev) phydev->priv = priv; mutex_init(&priv->mbox_lock); + if (gpy_has_broken_mdint(phydev) && + !device_property_present(dev, "maxlinear,use-broken-interrupts")) + phydev->irq = PHY_POLL; + fw_version = phy_read(phydev, PHY_FWV); if (fw_version < 0) return fw_version;
--
2.30.2