On 28.12.2022 23:05, Stephen Hemminger wrote:

On Wed, 28 Dec 2022 22:30:56 +0100
Heiner Kallweit [off-list ref] wrote:

quoted

There are still single reports of systems where ASPM incompatibilities
cause tx timeouts. It's not clear whom to blame, so let's disable
ASPM in case of a tx timeout.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>

Wouldn't a log message be appropriate here.

	netdev_WARN_ONCE(tp->dev, "ASPM disabled on Tx timeout\n");

Right, that's something I could add. Message will be printed only
if return code of pci_disable_link_state() indicates success.
And I'd use netdev_warn_once() instead of netdev_WARN_ONCE(),
because net core prints a stack trace already in case of tx timeout.