Re: [PATCH] virtio_net: send notification coalescing command only if value changed
From: Alvaro Karsz <alvaro.karsz@solid-run.com>
Date: 2022-12-21 12:45:03
Also in:
virtualization
Why do we bother? Resending needs more code and helps reliability ...
It just seems unnecessary. If a user changes just one parameter: $ ethtool -C <iface> tx-usecs 30 It will trigger 2 commands, including VIRTIO_NET_CTRL_NOTF_COAL_RX_SET, even though no rx parameter changed. If we'll add more ethtool coalescing parameters, changing one of the new parameter will trigger meaningless VIRTIO_NET_CTRL_NOTF_COAL_RX_SET and VIRTIO_NET_CTRL_NOTF_COAL_TX_SET commands. Alvaro