Thread (31 messages) 31 messages, 2 authors, 2022-12-10

Re: [PATCH net-next 02/14] bridge: mcast: Split (*, G) and (S, G) addition into different functions

From: Nikolay Aleksandrov <razor@blackwall.org>
Date: 2022-12-09 07:31:49
Also in: bridge

On 08/12/2022 17:28, Ido Schimmel wrote:
When the bridge is using IGMP version 3 or MLD version 2, it handles the
addition of (*, G) and (S, G) entries differently.

When a new (S, G) port group entry is added, all the (*, G) EXCLUDE
ports need to be added to the port group of the new entry. Similarly,
when a new (*, G) EXCLUDE port group entry is added, the port needs to
be added to the port group of all the matching (S, G) entries.

Subsequent patches will create more differences between both entry
types. Namely, filter mode and source list can only be specified for (*,
G) entries.

Given the current and future differences between both entry types,
handle the addition of each entry type in a different function, thereby
avoiding the creation of one complex function.

Signed-off-by: Ido Schimmel <idosch@nvidia.com>
---
 net/bridge/br_mdb.c | 145 +++++++++++++++++++++++++++++---------------
 1 file changed, 96 insertions(+), 49 deletions(-)
Acked-by: Nikolay Aleksandrov <razor@blackwall.org>

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help