On Wed, Dec 07, 2022 at 07:41:28PM +0000, David Laight wrote:
From: Dan Carpenter
quoted
Sent: 07 December 2022 12:21
....
quoted
quoted
quoted
- new_val |= (bit << (width - i - 1));
+ if (val & BIT_ULL(1))
hmm, why 1 and not i?
Because I'm a moron. Let me resend.
Since we're not writing FORTRAN-IV why not use a variable
name that is harder to confuse with 1?
How about 'k'?