[PATCH v2 net-next 08/16] pds_core: add fw bank select
From: Shannon Nelson <hidden>
Date: 2022-12-07 00:45:31
Subsystem:
networking drivers, pensando ethernet drivers, the rest · Maintainers:
Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Brett Creeley, Linus Torvalds
Add support for the fw_bank parameter to select the next bootup firmware. This can be selected at any time, and is also selected automatically when a new firmware is flashed into the device. There are three banks available in this device: 1 and 2 are the primaries for normal operations, while bank 3 has 'gold' firmware that can be selected and used as recovery fw in the case that both 1 and 2 become corrupt. Signed-off-by: Shannon Nelson <redacted> --- .../net/ethernet/pensando/pds_core/devlink.c | 71 +++++++++++++++++++ 1 file changed, 71 insertions(+)
diff --git a/drivers/net/ethernet/pensando/pds_core/devlink.c b/drivers/net/ethernet/pensando/pds_core/devlink.c
index 78fe657f6532..cd132573cbe0 100644
--- a/drivers/net/ethernet/pensando/pds_core/devlink.c
+++ b/drivers/net/ethernet/pensando/pds_core/devlink.c@@ -8,6 +8,69 @@ #include "core.h" +static int pdsc_dl_fw_bank_get(struct devlink *dl, u32 id, + struct devlink_param_gset_ctx *ctx) +{ + struct pdsc *pdsc = devlink_priv(dl); + union pds_core_dev_cmd cmd = { + .fw_control.opcode = PDS_CORE_CMD_FW_CONTROL, + .fw_control.oper = PDS_CORE_FW_GET_BOOT, + }; + union pds_core_dev_comp comp; + int err; + + err = pdsc_devcmd(pdsc, &cmd, &comp, pdsc->devcmd_timeout); + if (err) + return err; + + ctx->val.vu8 = comp.fw_control.slot; + + return 0; +} + +static int pdsc_dl_fw_bank_set(struct devlink *dl, u32 id, + struct devlink_param_gset_ctx *ctx) +{ + struct pdsc *pdsc = devlink_priv(dl); + union pds_core_dev_cmd cmd = { + .fw_control.opcode = PDS_CORE_CMD_FW_CONTROL, + .fw_control.oper = PDS_CORE_FW_SET_BOOT, + }; + union pds_core_dev_comp comp; + int timeout; + + cmd.fw_control.slot = ctx->val.vu8; + + /* This is known to be a longer running command, so be sure + * to use a larger timeout on the command than usual + */ +#define PDSC_SET_BOOT_TIMEOUT 10 + timeout = max_t(int, PDSC_SET_BOOT_TIMEOUT, pdsc->devcmd_timeout); + return pdsc_devcmd(pdsc, &cmd, &comp, timeout); +} + +static int pdsc_dl_fw_bank_validate(struct devlink *dl, u32 id, + union devlink_param_value val, + struct netlink_ext_ack *extack) +{ + switch (val.vu8) { + case PDS_CORE_FW_SLOT_A: + case PDS_CORE_FW_SLOT_B: + case PDS_CORE_FW_SLOT_GOLD: + return 0; + default: + return -EINVAL; + } +} + +static const struct devlink_param pdsc_dl_params[] = { + DEVLINK_PARAM_GENERIC(FW_BANK, + BIT(DEVLINK_PARAM_CMODE_PERMANENT), + pdsc_dl_fw_bank_get, + pdsc_dl_fw_bank_set, + pdsc_dl_fw_bank_validate), +}; + static int pdsc_dl_info_get(struct devlink *dl, struct devlink_info_req *req, struct netlink_ext_ack *extack) {
@@ -87,6 +150,12 @@ void pdsc_dl_free(struct pdsc *pdsc) int pdsc_dl_register(struct pdsc *pdsc) { struct devlink *dl = priv_to_devlink(pdsc); + int err; + + err = devlink_params_register(dl, pdsc_dl_params, + ARRAY_SIZE(pdsc_dl_params)); + if (err) + return err; devlink_register(dl);
@@ -98,4 +167,6 @@ void pdsc_dl_unregister(struct pdsc *pdsc) struct devlink *dl = priv_to_devlink(pdsc); devlink_unregister(dl); + devlink_params_unregister(dl, pdsc_dl_params, + ARRAY_SIZE(pdsc_dl_params)); }
--
2.17.1