Thread (24 messages) 24 messages, 6 authors, 2022-11-17

Re: [PATCH v3 3/3] treewide: use get_random_u32_inclusive() when possible

From: "Jason A. Donenfeld" <Jason@zx2c4.com>
Date: 2022-11-17 22:11:11
Also in: linux-arm-kernel, linux-block, linux-crypto, linux-fsdevel, linux-media, linux-mips, linux-mmc, linux-patches, linuxppc-dev, lkml, loongarch

On Thu, Nov 17, 2022 at 01:57:13PM -0800, Kees Cook wrote:
The only comment I have is that maybe these cases can just be left as-is
with _below()?
quoted
-             size_t len = get_random_u32_below(rs) + gs;
+             size_t len = get_random_u32_inclusive(gs, rs + gs - 1);
It seems like writing it in the form of base plus [0, limit) is clearer?

		size_t len = gs + get_random_u32_below(rs);

But there is only a handful, so *shrug*
Okay, I'll drop that one.

Jason
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help