Re: [PATCH 1/3] dt-bindings: net: sun7i-gmac: Fix snps,dwmac.yaml inheritance
From: Krzysztof Kozlowski <hidden>
Date: 2022-11-26 13:25:21
Also in:
linux-arm-kernel, linux-devicetree, linux-sunxi, lkml
On 25/11/2022 21:20, Samuel Holland wrote:
The sun7i-gmac binding extends snps,dwmac.yaml, and should accept all properties defined there, including "mdio", "resets", and "reset-names". However, validation currently fails for these properties because the local binding sets "unevaluatedProperties: false", and snps,dwmac.yaml is only included inside an allOf block. Fix this by referencing snps,dwmac.yaml at the top level.
I don't understand where is the problem and how does your patch solve it. The old syntax is correct and your change does nothing, no fixing, no impact. It actually looks like noop with big explanation :(
Signed-off-by: Samuel Holland <samuel@sholland.org> ---
Best regards, Krzysztof