Thread (27 messages) 27 messages, 3 authors, 2022-11-28

RE: [PATCH v3 06/11] rtw88: iterate over vif/sta list non-atomically

From: Ping-Ke Shih <pkshih@realtek.com>
Date: 2022-11-25 08:51:29
Also in: linux-wireless, lkml

-----Original Message-----
From: Sascha Hauer <s.hauer@pengutronix.de>
Sent: Tuesday, November 22, 2022 10:52 PM
To: linux-wireless@vger.kernel.org
Cc: Neo Jou <redacted>; Hans Ulli Kroll <redacted>; Ping-Ke Shih <pkshih@realtek.com>;
Yan-Hsuan Chuang [off-list ref]; Kalle Valo [off-list ref]; netdev@vger.kernel.org;
linux-kernel@vger.kernel.org; Martin Blumenstingl [off-list ref];
kernel@pengutronix.de; Johannes Berg [off-list ref]; Alexander Hochbaum [off-list ref];
Da Xue [off-list ref]; Bernie Huang [off-list ref]; Viktor Petrenko [off-list ref];
Sascha Hauer [off-list ref]
Subject: [PATCH v3 06/11] rtw88: iterate over vif/sta list non-atomically

The driver uses ieee80211_iterate_active_interfaces_atomic()
and ieee80211_iterate_stations_atomic() in several places and does
register accesses in the iterators. This doesn't cope with upcoming
USB support as registers can only be accessed non-atomically.

Split these into a two stage process: First use the atomic iterator
functions to collect all active interfaces or stations on a list, then
iterate over the list non-atomically and call the iterator on each
entry.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Suggested-by: Pkshih <pkshih@realtek.com>
Please correct my full name. The old setting of my mailer is improper.

Suggested-by: Ping-Ke Shih <pkshih@realtek.com>
Reviewed-by: Ping-Ke Shih <pkshih@realtek.com>

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help