Re: [PATCH 09/18] net: emac, cpsw: fix mixed module-builtin object (davinci_cpdma)
From: Masahiro Yamada <masahiroy@kernel.org>
Date: 2022-11-23 16:06:02
Also in:
linux-kbuild, lkml
On Sun, Nov 20, 2022 at 8:07 AM Alexander Lobakin [off-list ref] wrote:
From: Masahiro Yamada <masahiroy@kernel.org>
CONFIG_TI_DAVINCI_EMAC, CONFIG_TI_CPSW and CONFIG_TI_CPSW_SWITCHDEV
are all tristate. This means that davinci_cpdma.o can be linked to
a module and also to vmlinux even though the expected CFLAGS are
different between builtins and modules.
This is the same situation as fixed by commit 637a642f5ca5 ("zstd:
Fixing mixed module-builtin objects").
Introduce the new module, ti_davinci_cpdma, to provide the common
functions to these three modules.
[ alobakin: add exports ]
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Reviewed-by: Alexander Lobakin <redacted>
Signed-off-by: Alexander Lobakin <redacted>
---Please take the authorship for this patch because I did not finish this patch (and I am not sure if this is the correct way to fix) As 18/18 will touch this part again, perhaps davinci_cpdma.c can go into ti_cpsw_core.ko Anyway, the maintainer may have a better insight. -- Best Regards Masahiro Yamada