Re: [PATCH] lib/test_rhashtable: Remove set but unused variable 'insert_retries'

From
Herbert Xu <herbert@gondor.apana.org.au>
Date
2022-11-23 08:20:40
Also in
lkml
Reply to
Jiapeng Chong, 2022-11-23
On Wed, Nov 23, 2022 at 11:59:51AM +0800, Jiapeng Chong wrote:
quoted hunk ↗ jump to hunk
@@ -447,9 +447,7 @@ static int __init test_rhashtable_max(struct test_obj *array,
 
 		obj->value.id = i * 2;
 		err = insert_retry(&ht, obj, test_rht_params);
-		if (err > 0)
-			insert_retries += err;
-		else if (err)
+		if (err)
This is wrong as you will now abort on a retried insertion.  You
should instead test for err < 0.

Thanks,
-- 
Email: Herbert Xu [off-list ref]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Thread (2 messages) 2 messages, 2 authors, last reply 2022-11-23
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help