Thread (25 messages) 25 messages, 9 authors, 2022-12-09

Re: [PATCH v1 2/3] Treewide: Stop corrupting socket's task_frag

From: Benjamin Coddington <hidden>
Date: 2022-11-22 14:25:03
Also in: ceph-devel, linux-block, linux-cifs, linux-nfs, linux-nvme, linux-scsi, linux-usb, lkml, ocfs2-devel

On 21 Nov 2022, at 17:32, Shuah Khan wrote:
On 11/21/22 15:01, Benjamin Coddington wrote:
quoted
On 21 Nov 2022, at 16:43, Shuah Khan wrote:
quoted
On 11/21/22 14:40, Shuah Khan wrote:
quoted
On 11/21/22 07:34, Benjamin Coddington wrote:
quoted
On 21 Nov 2022, at 8:56, David Howells wrote:
quoted
Benjamin Coddington [off-list ref] wrote:
quoted
Since moving to memalloc_nofs_save/restore, SUNRPC has stopped setting the
GFP_NOIO flag on sk_allocation which the networking system uses to decide
when it is safe to use current->task_frag.
Um, what's task_frag?
Its a per-task page_frag used to coalesce small writes for networking -- see:

5640f7685831 net: use a per task frag allocator

Ben
I am not seeing this in the mainline. Where can find this commit?
Okay. I see this commit in the mainline. However, I don't see the
sk_use_task_frag in mainline.
sk_use_task_frag is in patch 1/3 in this posting.

https://lore.kernel.org/netdev/26d98c8f-372b-b9c8-c29f-096cddaff149@linuxfoundation.org/T/#m3271959c4cf8dcff1c0c6ba023b2b3821d9e7e99 (local)
Aha. I don't have 1/3 in my Inbox - I think it would make
sense to cc people on the first patch so we can understand
the premise for the change.
Yeah, I can do that if it goes to another version, I was just trying to be
considerate of all the noise this sort of posting generates.

Ben
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help