Re: [PATCH] can: can327: fix potential skb leak when netdev is down
From: Max Staudt <max@enpas.org>
Date: 2022-11-22 10:10:13
Also in:
linux-can, lkml
From: Max Staudt <max@enpas.org>
Date: 2022-11-22 10:10:13
Also in:
linux-can, lkml
Marc, Wolfgang, Could you please include William's patch to can327, provided that you see no issue with it? Thanks :) Max On Tue, 22 Nov 2022 10:10:50 +0800 "Ziyang Xuan (William)" [off-list ref] wrote:
Hello, Gently ask. Is there any other problem? And can it be applied? Thanks.quoted
(CC Vincent, he may be interested) On Thu, 10 Nov 2022 14:14:37 +0800 Ziyang Xuan [off-list ref] wrote:quoted
Fix it by adding kfree_skb() in can327_feed_frame_to_netdev() when netdev is down. Not tested, just compiled.Looks correct to me, so: Reviewed-by: Max Staudt <max@enpas.org> Thank you very much for finding and fixing this! Max .