Re: [RFC PATCH 1/9] dt-bindings: drop redundant part of title of shared bindings
From: Conor Dooley <conor@kernel.org>
Date: 2022-11-17 17:53:04
Also in:
alsa-devel, linux-arm-kernel, linux-arm-msm, linux-can, linux-clk, linux-devicetree, linux-gpio, linux-iio, linux-input, linux-leds, linux-media, linux-mips, linux-mmc, linux-pci, linux-pm, linux-pwm, linux-riscv, linux-rtc, linux-serial, linux-spi, linux-usb, linux-watchdog, lkml
On Thu, Nov 17, 2022 at 01:38:42PM +0100, Krzysztof Kozlowski wrote:
The Devicetree bindings document does not have to say in the title that it is a "binding", but instead just describe the hardware. For shared (re-usable) schemas, name them all as "common properties".
quoted hunk ↗ jump to hunk
diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc.yaml index 1ab416c83c8d..d2de3d128b73 100644 --- a/Documentation/devicetree/bindings/clock/qcom,gcc.yaml +++ b/Documentation/devicetree/bindings/clock/qcom,gcc.yaml@@ -4,7 +4,7 @@ $id: http://devicetree.org/schemas/clock/qcom,gcc.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml# -title: Qualcomm Global Clock & Reset Controller Common Bindings +title: Qualcomm Global Clock & Reset Controller common parts maintainers: - Stephen Boyd <sboyd@kernel.org>
quoted hunk ↗ jump to hunk
diff --git a/Documentation/devicetree/bindings/opp/opp-v2-base.yaml b/Documentation/devicetree/bindings/opp/opp-v2-base.yaml index cf9c2f7bddc2..20ac432dc683 100644 --- a/Documentation/devicetree/bindings/opp/opp-v2-base.yaml +++ b/Documentation/devicetree/bindings/opp/opp-v2-base.yaml@@ -4,7 +4,7 @@ $id: http://devicetree.org/schemas/opp/opp-v2-base.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml# -title: Generic OPP (Operating Performance Points) Common Binding +title: Generic OPP (Operating Performance Points) common parts maintainers: - Viresh Kumar <viresh.kumar@linaro.org>
Hey Krzysztof, Hopefully I've not overlooked something obvious, but it wasnt noted in the commit message - how come these two are "parts" rather than "properties"? The opp one at least don't seem to have much more than properties and patterProperties in it. Thanks, Conor.