RE: [EXT] Re: [PATCH v3 1/1] net: fec: add initial XDP support
From: Shenwei Wang <shenwei.wang@nxp.com>
Date: 2022-11-03 14:53:58
Also in:
imx, lkml
From: Shenwei Wang <shenwei.wang@nxp.com>
Date: 2022-11-03 14:53:58
Also in:
imx, lkml
-----Original Message----- From: Paolo Abeni <pabeni@redhat.com>quoted
+ if (unlikely(index < 0)) + index = 0; + + while (index >= fep->num_tx_queues) + index -= fep->num_tx_queues;Not a big deal, but I think kind of optimizations are not worthy and potentially dangerous since late '90 ;) You could consider switching to a simpler '%', but IMHO it's not blocking.
Agree. Will optimize it in next patch of adding xdp statistics. Thanks, Shenwei
Cheers, Paolo