On 11/28/22 10:29 AM, Jakub Kicinski wrote:

On Fri, 18 Nov 2022 14:56:47 -0800 Shannon Nelson wrote:

quoted

+     DEVLINK_PARAM_DRIVER(PDSC_DEVLINK_PARAM_ID_LM,
+                          "enable_lm",
+                          DEVLINK_PARAM_TYPE_BOOL,
+                          BIT(DEVLINK_PARAM_CMODE_RUNTIME),
+                          pdsc_dl_enable_get,
+                          pdsc_dl_enable_set,
+                          pdsc_dl_enable_validate),

Terrible name, not vendor specific.

... but useful for starting a conversation.

How about we add
	DEVLINK_PARAM_GENERIC_ID_ENABLE_LM,

to live along with the existing
	DEVLINK_PARAM_GENERIC_ID_ENABLE_RDMA,
	DEVLINK_PARAM_GENERIC_ID_ENABLE_VNET,

By the way, thanks for your time looking through these patches.

Cheers,
sln