Re: [PATCH net-next 5/7] sctp: add dif and sdif check in asoc and ep lookup
From: Paolo Abeni <pabeni@redhat.com>
Date: 2022-11-15 10:20:39
Also in:
linux-sctp, llvm, oe-kbuild-all
On Mon, 2022-11-14 at 21:38 -0500, Xin Long wrote:
On Sun, Nov 13, 2022 at 3:15 PM kernel test robot [off-list ref] wrote:quoted
Hi Xin, Thank you for the patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/intel-lab-lkp/linux/commits/Xin-Long/sctp-support-vrf-processing/20221114-004540 patch link: https://lore.kernel.org/r/86dfdc49613ca8a8a6a3d7c7cf2e7bd8207338f2.1668357542.git.lucien.xin%40gmail.com patch subject: [PATCH net-next 5/7] sctp: add dif and sdif check in asoc and ep lookup config: arm-randconfig-r034-20221114 compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 463da45892e2d2a262277b91b96f5f8c05dc25d0) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install arm cross compiling tool for clang build # apt-get install binutils-arm-linux-gnueabi # https://github.com/intel-lab-lkp/linux/commit/6129dc2e382c6e2d3198f6c32cc1f750a15a77ab git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Xin-Long/sctp-support-vrf-processing/20221114-004540 git checkout 6129dc2e382c6e2d3198f6c32cc1f750a15a77ab # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash net/openvswitch/ If you fix the issue, kindly add following tag where applicablequoted
Reported-by: kernel test robot <redacted>All errors (new ones prefixed by >>): In file included from net/openvswitch/actions.c:26: In file included from include/net/sctp/checksum.h:27:quoted
quoted
include/net/sctp/sctp.h:686:35: error: no member named 'sctp' in 'struct net'l3mdev_accept = !!READ_ONCE(net->sctp.l3mdev_accept); ~~~ ^The build disabled IP_SCTP, while net/sctp/sctp.h is included in other modules. Instead of "net/sctp/sctp.h", "linux/sctp.h" should be included, I will send another patch series to fix them. We do NOT need to change anything in this series.
'net->sctp' is defined only when CONFIG_SCTP is enabled. AFAICS the new helper introduced by this patch is the only function in sctp.h accessing 'net->sctp', so prior to this patch including sctp.h with # CONFIG_SCTP is not set was apparently safe, while not it breaks the build. I think the issue should be addressed here. Thanks, Paolo