Thread (13 messages) 13 messages, 2 authors, 2022-11-15

Re: [PATCH net-next v11 08/11] ice: Implement devlink-rate API

From: Jakub Kicinski <kuba@kernel.org>
Date: 2022-11-15 05:11:44

On Mon, 14 Nov 2022 18:31:35 +0100 Michal Wilczynski wrote:
There is a need to support modification of Tx scheduler tree, in the
ice driver. This will allow user to control Tx settings of each node in
the internal hierarchy of nodes. As a result user will be able to use
Hierarchy QoS implemented entirely in the hardware.

This patch implemenents devlink-rate API. It also exports initial
default hierarchy. It's mostly dictated by the fact that the tree
can't be removed entirely, all we can do is enable the user to modify
it. For example root node shouldn't ever be removed, also nodes that
have children are off-limits.
drivers/net/ethernet/intel/ice/ice_devlink.c:794: warning: Function parameter or member 'bw' not described in 'ice_set_object_tx_share'
drivers/net/ethernet/intel/ice/ice_devlink.c:818: warning: Function parameter or member 'bw' not described in 'ice_set_object_tx_max'
drivers/net/ethernet/intel/ice/ice_devlink.c:842: warning: Function parameter or member 'priority' not described in 'ice_set_object_tx_priority'
drivers/net/ethernet/intel/ice/ice_devlink.c:871: warning: Function parameter or member 'weight' not described in 'ice_set_object_tx_weight'

Feel free to post a v12 with these fixed, I'll review the latest
tomorrow.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help