Re: [PATCH net-next v10 10/10] ice: add documentation for devlink-rate implementation
From: Wilczynski, Michal <hidden>
Date: 2022-11-10 17:40:17
From: Wilczynski, Michal <hidden>
Date: 2022-11-10 17:40:17
On 11/10/2022 6:03 PM, Jakub Kicinski wrote:
On Thu, 10 Nov 2022 17:54:03 +0100 Wilczynski, Michal wrote:quoted
quoted
Nice, but in case DCB or TC/ADQ gets enabled devlink rate will just show a stale hierarchy?Yes there will be hierarchy exported during the VF creation, so if the user enable DCB/ADQ in the meantime, it will be a stale hierarchy. User won't be able to modify any nodes/parameters.Why not tear it down if it's stale?
I don't think there is any harm in tearing it down in those cases, can add a commit that tears down the hierarchy when DCB/ADQ gets activated.