Re: [f2fs-dev] [PATCH v1 3/5] treewide: use get_random_u32() when possible
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: 2022-10-06 13:01:48
Also in:
ceph-devel, dmaengine, dri-devel, linux-block, linux-crypto, linux-doc, linux-ext4, linux-f2fs-devel, linux-fbdev, linux-fsdevel, linux-hams, linux-media, linux-mmc, linux-nfs, linux-nvme, linux-raid, linux-rdma, linux-scsi, linux-sctp, linux-usb, linux-wireless, linux-xfs, linuxppc-dev, lkml, lvs-devel, netfilter-devel, target-devel
On Thu, Oct 06, 2022 at 06:33:15AM -0600, Jason A. Donenfeld wrote:
On Thu, Oct 06, 2022 at 10:43:31AM +0200, Jan Kara wrote:
...
quoted
The code here is effectively doing the parent_group = prandom_u32_max(ngroups); Similarly here we can use prandom_u32_max(ngroups) like: if (qstr) { ... parent_group = hinfo.hash % ngroups; } else parent_group = prandom_u32_max(ngroups);Nice catch. I'll move these to patch #1.
I believe coccinelle is able to handle this kind of code as well, so Kees' proposal to use it seems more plausible since it's less error prone and more flexible / powerful. -- With Best Regards, Andy Shevchenko