Thread (4 messages) 4 messages, 3 authors, 2022-10-31

Re: [ovs-dev] [PATCH net] openvswitch: add missing resv_start_op initialization for dp_vport_genl_family

From: Ilya Maximets <i.maximets@ovn.org>
Date: 2022-10-31 11:39:22
Also in: lkml

On 10/31/22 09:12, Ziyang Xuan via dev wrote:
I got a warning using the latest mainline codes to start vms as following:

===================================================
WARNING: CPU: 1 PID: 1 at net/netlink/genetlink.c:383 genl_register_family+0x6c/0x76c
CPU: 1 PID: 1 Comm: swapper/0 Not tainted 6.1.0-rc2-00886-g882ad2a2a8ff #43
...
Call trace:
 genl_register_family+0x6c/0x76c
 dp_init+0xa8/0x124
 do_one_initcall+0x84/0x450

It is because that commit 9c5d03d36251 ("genetlink: start to validate
reserved header bytes") has missed the resv_start_op initialization
for dp_vport_genl_family, and commit ce48ebdd5651 ("genetlink: limit
the use of validation workarounds to old ops") add checking warning.

Add resv_start_op initialization for dp_vport_genl_family to fix it.

Fixes: 9c5d03d36251 ("genetlink: start to validate reserved header bytes")
Signed-off-by: Ziyang Xuan <redacted>
---
Hi, Ziyang Xuan.  Thanks for the patch!

But it looks like Jakub already fixed that issue a couple of days ago:
  https://git.kernel.org/netdev/net/c/e4ba4554209f

Best regards, Ilya Maximets.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help