Re: [RFC 5/5] bluetooth: hci_mrvl: allow waiting for firmware load using notify-device
From: Krzysztof Kozlowski <hidden>
Date: 2022-10-26 17:22:20
Also in:
linux-bluetooth, linux-devicetree, linux-wireless, lkml
On 26/10/2022 09:15, Matthias Schiffer wrote:
quoted hunk ↗ jump to hunk
Signed-off-by: Matthias Schiffer <redacted> --- drivers/bluetooth/hci_mrvl.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+)diff --git a/drivers/bluetooth/hci_mrvl.c b/drivers/bluetooth/hci_mrvl.c index b7d764e6010f..dc55053574a9 100644 --- a/drivers/bluetooth/hci_mrvl.c +++ b/drivers/bluetooth/hci_mrvl.c@@ -12,6 +12,7 @@ #include <linux/skbuff.h> #include <linux/firmware.h> #include <linux/module.h> +#include <linux/notify-device.h> #include <linux/tty.h> #include <linux/of.h> #include <linux/of_device.h>@@ -433,9 +434,25 @@ static int mrvl_serdev_probe(struct serdev_device *serdev) return -ENOMEM; if (IS_ENABLED(CONFIG_OF)) { + struct device_node *firmware_ready_node; + struct device *firmware_ready; + mrvldev->info = of_device_get_match_data(&serdev->dev); if (!mrvldev->info) return -ENODEV; + + firmware_ready_node = of_parse_phandle(serdev->dev.of_node, + "firmware-ready", 0);
So you want us to go through five patches, find properties and OF-code, create in our minds bindings you think about and comment on that imaginary bindings. I think it should work otherwise - send bindings for all of your DT properties. Best regards, Krzysztof