Thread (1 message) 1 message, 1 author, 2022-10-20

Re: [PATCH v3] wifi: rt2x00: use explicitly signed or unsigned types

From: Kalle Valo <kvalo@kernel.org>
Date: 2022-10-20 10:36:21
Also in: linux-wireless, lkml

Stanislaw Gruszka [off-list ref] writes:
On Wed, Oct 19, 2022 at 09:55:41AM -0600, Jason A. Donenfeld wrote:
quoted
On some platforms, `char` is unsigned, but this driver, for the most
part, assumed it was signed. In other places, it uses `char` to mean an
unsigned number, but only in cases when the values are small. And in
still other places, `char` is used as a boolean. Put an end to this
confusion by declaring explicit types, depending on the context.

Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Stanislaw Gruszka <stf_xl@wp.pl>
Cc: Helmut Schaa <redacted>
Cc: Kalle Valo <kvalo@kernel.org>
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Acked-by: Stanislaw Gruszka <stf_xl@wp.pl>
Thanks, I'll queue this to v6.1.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help