Re: [PATCH v2 net-next 6/6] netlink: add universal 'bigint' attribute type

From
Alexander Lobakin <hidden>
Date
2022-10-19 15:42:37
Also in
lkml
Reply to
Jakub Kicinski, 2022-10-18
From: Jakub Kicinski <kuba@kernel.org>
Date: Tue, 18 Oct 2022 12:53:58 -0700
On Tue, 18 Oct 2022 16:00:27 +0200 Alexander Lobakin wrote:
quoted
@@ -235,12 +236,15 @@ enum nla_policy_validation {
  *                         given type fits, using it verifies minimum length
  *                         just like "All other"
  *    NLA_BITFIELD32       Unused
+ *    NLA_BIGINT           Number of bits in the big integer
[...]
quoted
+		break;
+
Very good stuff, the validation vs type separation is the big question.
Another round of great comments, copied to the TODO. Will dig out
everything and return with v3, for now at least most of those sound
possible and reasonable.

Thanks,
Olek
Thread (17 messages) 17 messages, 4 authors, last reply 2022-10-20
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help