Re: [PATCH 3/6][next] ipw2x00: Remove unnecessary cast to iw_handler in ipw_wx_handlers

From
Kees Cook <hidden>
Date
2022-10-18 02:44:15
Also in
linux-hardening, linux-wireless, lkml
Reply to
Gustavo A. R. Silva, 2022-10-17
On Mon, Oct 17, 2022 at 03:34:48PM -0500, Gustavo A. R. Silva wrote:
Previous patches have removed the rest of the casts to iw_handler in
ipw_wx_handlers array definition, and with that multiple
-Wcast-function-type-strict warnings have been fixed.

Remove the one cast to iw_handler remaining, which was not removed in
previous patches because there was no -Wcast-function-type-strict warning
associated with it.

Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
 /* Rebase the WE IOCTLs to zero for the handler array */
 static iw_handler ipw_wx_handlers[] = {
-	IW_HANDLER(SIOCGIWNAME, (iw_handler)cfg80211_wext_giwname),
+	IW_HANDLER(SIOCGIWNAME, cfg80211_wext_giwname),
 	IW_HANDLER(SIOCSIWFREQ, ipw_wx_set_freq),
 	IW_HANDLER(SIOCGIWFREQ, ipw_wx_get_freq),
 	IW_HANDLER(SIOCSIWMODE, ipw_wx_set_mode),
I'd just collapse this into the previous cfg80211_wext patch...

-- 
Kees Cook
Thread (15 messages) 15 messages, 3 authors, last reply 2022-10-19
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help