Thread (7 messages) 7 messages, 3 authors, 2022-10-21

Re: [PATCH net-next 1/3] sctp: remove unnecessary NULL check in sctp_association_init()

From: patchwork-bot+netdevbpf@kernel.org
Date: 2022-10-21 05:11:06
Also in: linux-sctp

Hello:

This series was applied to netdev/net-next.git (master)
by Jakub Kicinski [off-list ref]:

On Wed, 19 Oct 2022 21:07:33 +0300 you wrote:
'&asoc->ulpq' passed to sctp_ulpq_init() as the first argument,
then sctp_qlpq_init() initializes it and eventually returns the
address of the struct member back. Therefore, in this case, the
return pointer cannot be NULL.

Moreover, it seems sctp_ulpq_init() has always been used only in
sctp_association_init(), so there's really no need to return ulpq
anymore.

[...]
Here is the summary with links:
  - [net-next,1/3] sctp: remove unnecessary NULL check in sctp_association_init()
    https://git.kernel.org/netdev/net-next/c/6fdfdef7fdb5
  - [net-next,2/3] sctp: remove unnecessary NULL check in sctp_ulpq_tail_event()
    https://git.kernel.org/netdev/net-next/c/b66aeddbe30c
  - [net-next,3/3] sctp: remove unnecessary NULL checks in sctp_enqueue_event()
    https://git.kernel.org/netdev/net-next/c/377eb9aab084

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help