Re: [RFC PATCH v2 0/3] Create common DPLL/clock configuration API
From: Jiri Pirko <jiri@resnulli.us>
Date: 2022-09-30 08:34:05
Also in:
linux-arm-kernel, linux-clk
Fri, Sep 30, 2022 at 02:44:25AM CEST, vfedorenko@novek.ru wrote:
On 29.09.2022 12:40, Jiri Pirko wrote:quoted
Sun, Jun 26, 2022 at 09:24:41PM CEST, vfedorenko@novek.ru wrote:quoted
From: Vadim Fedorenko <redacted> Implement common API for clock/DPLL configuration and status reporting. The API utilises netlink interface as transport for commands and event notifications. This API aim to extend current pin configuration and make it flexible and easy to cover special configurations.Do you have the userspace part somewhere? It is very nice to add example outputs of user cmdline of such tool to the patch description/cover letter.Sorry, but we don't have any user-space part for now. It's still WIP and there are too many changes in the protocol to implement anything useful on
What protocol?
top of it. Once we will get to a kind of "stable" proto, I will implement a library to use it.quoted
Also, did you consider usage of sysfs? Why it isn't a better fit than netlink?We already have sysfs implemented in the ptp_ocp driver. But it looks like more hardware is going to be available soon with almost the same functions, so it would be great to have common protocol to configure such devices.
Sure, but more hw does not mean you can't use sysfs. Take netdev as an example. The sysfs exposed for it is implemented net/core/net-sysfs.c and is exposed for all netdev instances, no matter what the driver/hardware is.
quoted
Regarding the naming, is "dpll" the correct one. Forgive me for being a syncE greenie, but isn't dpll just one algo to achieve syntonous clocks? Perhaps "dco" as for "Digitally Controlled Oscillator" would be somewhat better fit?We will discuss the naming too, thanks!quoted
quoted
v1 -> v2: * implement returning supported input/output types * ptp_ocp: follow suggestions from Jonathan * add linux-clk mailing list v0 -> v1: * fix code style and errors * add linux-arm mailing list Vadim Fedorenko (3): dpll: Add DPLL framework base functions dpll: add netlink events ptp_ocp: implement DPLL ops MAINTAINERS | 8 + drivers/Kconfig | 2 + drivers/Makefile | 1 + drivers/dpll/Kconfig | 7 + drivers/dpll/Makefile | 7 + drivers/dpll/dpll_core.c | 161 ++++++++++ drivers/dpll/dpll_core.h | 40 +++ drivers/dpll/dpll_netlink.c | 595 ++++++++++++++++++++++++++++++++++++ drivers/dpll/dpll_netlink.h | 14 + drivers/ptp/Kconfig | 1 + drivers/ptp/ptp_ocp.c | 169 +++++++--- include/linux/dpll.h | 29 ++ include/uapi/linux/dpll.h | 81 +++++ 13 files changed, 1079 insertions(+), 36 deletions(-) create mode 100644 drivers/dpll/Kconfig create mode 100644 drivers/dpll/Makefile create mode 100644 drivers/dpll/dpll_core.c create mode 100644 drivers/dpll/dpll_core.h create mode 100644 drivers/dpll/dpll_netlink.c create mode 100644 drivers/dpll/dpll_netlink.h create mode 100644 include/linux/dpll.h create mode 100644 include/uapi/linux/dpll.h -- 2.27.0