Thread (11 messages) 11 messages, 4 authors, 2022-09-30

Re: [PATCH RFC net-next 0/5] net: vlan: fix bridge binding behavior and add selftests

From: Jakub Kicinski <kuba@kernel.org>
Date: 2022-09-20 23:30:10
Also in: bridge, lkml

On Tue, 20 Sep 2022 12:16:26 +0300 Nikolay Aleksandrov wrote:
The set looks good to me, the bridge and vlan direct dependency is gone and
the new notification type is used for passing link type specific info.
IDK, vlan knows it's calling the bridge:

+	if ((vlan->flags ^ old_flags) & VLAN_FLAG_BRIDGE_BINDING &&
+	    netif_is_bridge_master(vlan->real_dev)) {

bridge knows it's vlan calling:

+	if (is_vlan_dev(dev)) {
+		br_vlan_device_event(dev, event, ptr);

going thru the generic NETDEV notifier seems odd.

If this is just to avoid the dependency we can perhaps add a stub 
like net/ipv4/udp_tunnel_stub.c ?
If the others are ok with it I think you can send it as non-RFC, but I'd give it
a few more days at least. :)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help