Thread (14 messages) flat view 14 messages, 3 authors, 2022-09-20

Re: [PATCH v2 net-next 03/10] net: dsa: allow the DSA master to be seen and changed through rtnetlink

From: Paolo Abeni <pabeni@redhat.com>
Date: 2022-09-20 09:25:13
Also in: lkml

Hello,

On Sun, 2022-09-11 at 14:35 +0000, Vladimir Oltean wrote:
On Sun, Sep 11, 2022 at 04:06:59AM +0300, Vladimir Oltean wrote:
quoted
+struct rtnl_link_ops dsa_link_ops __read_mostly = {
+	.kind			= "dsa",
+	.priv_size		= sizeof(struct dsa_port),
+	.maxtype		= IFLA_DSA_MAX,
+	.policy			= dsa_policy,
+	.changelink		= dsa_changelink,
+	.get_size		= dsa_get_size,
+	.fill_info		= dsa_fill_info,
+};
I forgot to apply Jakub's suggestion to set netns_refund = true.
On the other hand, I think the patches are otherwise fine, and I
wouldn't resend them, especially without any feedback. If there is no
other feedback, can I fix this up through an incremental patch?
Since the delta should be minimal, we have a significant backlog, and
this LGTM, I'm going to apply the series as-is.

Please follow-up with the incremental fix, thanks,

Paolo
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help