RE: [PATCH] net: mana: Fix return type of mana_start_xmit
From: Dexuan Cui <decui@microsoft.com>
Date: 2022-09-12 21:56:19
Also in:
linux-hyperv, lkml, llvm
From: Dexuan Cui <decui@microsoft.com>
Date: 2022-09-12 21:56:19
Also in:
linux-hyperv, lkml, llvm
From: Nathan Huckleberry <redacted> Sent: Monday, September 12, 2022 2:44 PM ... The ndo_start_xmit field in net_device_ops is expected to be of type netdev_tx_t (*ndo_start_xmit)(struct sk_buff *skb, struct net_device *dev). The mismatched return type breaks forward edge kCFI since the underlying function definition does not match the function hook definition. The return type of mana_start_xmit should be changed from int to netdev_tx_t. Reported-by: Dan Carpenter <redacted> Link: ... Cc: llvm@lists.linux.dev Signed-off-by: Nathan Huckleberry <redacted>
Reviewed-by: Dexuan Cui <decui@microsoft.com> Thanks for the fix!