Thread (11 messages) 11 messages, 2 authors, 2022-09-08

Re: [PATCH v3 1/6] udp: allow header check for dodgy GSO_UDP_L4 packets.

From: Andrew Melnichenko <hidden>
Date: 2022-09-08 20:23:36
Also in: lkml, virtualization

Hi all,

On Thu, Sep 8, 2022 at 3:40 AM David Ahern [off-list ref] wrote:
On 9/7/22 6:50 AM, Andrew Melnychenko wrote:
quoted
diff --git a/net/ipv4/udp_offload.c b/net/ipv4/udp_offload.c
index 6d1a4bec2614..8e002419b4d5 100644
--- a/net/ipv4/udp_offload.c
+++ b/net/ipv4/udp_offload.c
@@ -387,7 +387,7 @@ static struct sk_buff *udp4_ufo_fragment(struct sk_buff *skb,
      if (!pskb_may_pull(skb, sizeof(struct udphdr)))
              goto out;

-     if (skb_shinfo(skb)->gso_type & SKB_GSO_UDP_L4)
+     if (skb_shinfo(skb)->gso_type & SKB_GSO_UDP_L4 && !skb_gso_ok(skb, features | NETIF_F_GSO_ROBUST))
that line needs to be wrapped.
Ok, I'll wrap it.
quoted
              return __udp_gso_segment(skb, features, false);

      mss = skb_shinfo(skb)->gso_size;
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help