Re: [PATCH v8 01/26] tcp: authopt: Initial support and key management
From: Paolo Abeni <pabeni@redhat.com>
Date: 2022-09-08 06:36:22
Also in:
linux-crypto, linux-kselftest, lkml
On Mon, 2022-09-05 at 10:05 +0300, Leonard Crestez wrote: [...]
quoted hunk ↗ jump to hunk
diff --git a/net/ipv4/tcp_authopt.c b/net/ipv4/tcp_authopt.c new file mode 100644 index 000000000000..d38e9c89c89d --- /dev/null +++ b/net/ipv4/tcp_authopt.c@@ -0,0 +1,317 @@ +// SPDX-License-Identifier: GPL-2.0-or-later + +#include <net/tcp_authopt.h> +#include <net/ipv6.h> +#include <net/tcp.h> +#include <linux/kref.h> + +/* This is enabled when first struct tcp_authopt_info is allocated and never released */ +DEFINE_STATIC_KEY_FALSE(tcp_authopt_needed_key); +EXPORT_SYMBOL(tcp_authopt_needed_key); + +static inline struct netns_tcp_authopt *sock_net_tcp_authopt(const struct sock *sk) +{ + return &sock_net(sk)->tcp_authopt; +}
Please have a look at PW report for this series, there are a bunch of issues to be addressed, e.g. above 'static inline' should be just 'static'
+
+static void tcp_authopt_key_release_kref(struct kref *ref)
+{
+ struct tcp_authopt_key_info *key = container_of(ref, struct tcp_authopt_key_info, ref);
+
+ kfree_rcu(key, rcu);
+}
+
+static void tcp_authopt_key_put(struct tcp_authopt_key_info *key)
+{
+ if (key)
+ kref_put(&key->ref, tcp_authopt_key_release_kref);
+}
+
+static void tcp_authopt_key_del(struct netns_tcp_authopt *net,
+ struct tcp_authopt_key_info *key)
+{
+ lockdep_assert_held(&net->mutex);
+ hlist_del_rcu(&key->node);
+ key->flags |= TCP_AUTHOPT_KEY_DEL;
+ kref_put(&key->ref, tcp_authopt_key_release_kref);
+}
+
+/* Free info and keys.
+ * Don't touch tp->authopt_info, it might not even be assigned yes.
+ */
+void tcp_authopt_free(struct sock *sk, struct tcp_authopt_info *info)this need to be 'static'. I'm sorry to bring the next topic this late (If already discussed, I missed that point), is possible to split this series in smaller chunks? Cheers, Paolo