Re: [PATCH 25/31] selftests/net: Add TCP-AO library

On 8/23/22 16:47, Shuah Khan wrote:

On 8/18/22 10:59 AM, Dmitry Safonov wrote:

quoted

Provide functions to create selftests dedicated to TCP-AO.
They can run in parallel, as they use temporary net namespaces.
They can be very specific to the feature being tested.
This will allow to create a lot of TCP-AO tests, without complicating
one binary with many --options and to create scenarios, that are
hard to put in bash script that uses one binary.

Signed-off-by: Dmitry Safonov <redacted>
---
  tools/testing/selftests/Makefile              |   1 +
  tools/testing/selftests/net/tcp_ao/.gitignore |   2 +
  tools/testing/selftests/net/tcp_ao/Makefile   |  45 +++
  tools/testing/selftests/net/tcp_ao/connect.c  |  81 +++++
  .../testing/selftests/net/tcp_ao/lib/aolib.h  | 333 +++++++++++++++++
  .../selftests/net/tcp_ao/lib/netlink.c        | 341 ++++++++++++++++++
  tools/testing/selftests/net/tcp_ao/lib/proc.c | 267 ++++++++++++++
  .../testing/selftests/net/tcp_ao/lib/setup.c  | 297 +++++++++++++++
  tools/testing/selftests/net/tcp_ao/lib/sock.c | 294 +++++++++++++++
  .../testing/selftests/net/tcp_ao/lib/utils.c  |  30 ++
  10 files changed, 1691 insertions(+)
  create mode 100644 tools/testing/selftests/net/tcp_ao/.gitignore
  create mode 100644 tools/testing/selftests/net/tcp_ao/Makefile
  create mode 100644 tools/testing/selftests/net/tcp_ao/connect.c
  create mode 100644 tools/testing/selftests/net/tcp_ao/lib/aolib.h
  create mode 100644 tools/testing/selftests/net/tcp_ao/lib/netlink.c
  create mode 100644 tools/testing/selftests/net/tcp_ao/lib/proc.c
  create mode 100644 tools/testing/selftests/net/tcp_ao/lib/setup.c
  create mode 100644 tools/testing/selftests/net/tcp_ao/lib/sock.c
  create mode 100644 tools/testing/selftests/net/tcp_ao/lib/utils.c

diff --git a/tools/testing/selftests/Makefile

b/tools/testing/selftests/Makefile
index 10b34bb03bc1..2a3b15a13ccb 100644

--- a/tools/testing/selftests/Makefile
+++ b/tools/testing/selftests/Makefile

@@ -46,6 +46,7 @@ TARGETS += net

  TARGETS += net/af_unix
  TARGETS += net/forwarding
  TARGETS += net/mptcp
+TARGETS += net/tcp_ao

Please look into a wayto invoke all of them instead of adding individual
net/* to the main Makefile. This list seems to be growing. :)

Sent a patch separately to allow sub-dir defining their $(TARGETS):
https://lore.kernel.org/all/20220905202108.89338-1-dima@arista.com/T/#u (local)

Will rebase this patch set if the other gets in :)

quoted

  TARGETS += netfilter
  TARGETS += nsfs
  TARGETS += pidfd

[snip]

[..]
Thanks,
          Dmitry