Re: [PATCHv5 net-next 2/4] net: add new helper unregister_netdevice_many_notify

On Fri, Sep 30, 2022 at 06:31:42PM +0200, Guillaume Nault wrote:

On Fri, Sep 30, 2022 at 05:45:04PM +0800, Hangbin Liu wrote:

quoted

@@ -10779,11 +10779,14 @@ EXPORT_SYMBOL(unregister_netdevice_queue);
 /**
  *	unregister_netdevice_many - unregister many devices
  *	@head: list of devices
+ *	@nlh: netlink message header
+ *	@pid: destination netlink portid for reports
  *
  *  Note: As most callers use a stack allocated list_head,
  *  we force a list_del() to make sure stack wont be corrupted later.
  */
-void unregister_netdevice_many(struct list_head *head)
+void unregister_netdevice_many_notify(struct list_head *head,
+				      struct nlmsghdr *nlh, u32 pid)

Let's use portid (not pid) here too.

...and make 'nlh' const.