Re: [PATCHv3 net-next] rtnetlink: Honour NLM_F_ECHO flag in rtnl_{new, set, del}link
From: Hangbin Liu <hidden>
Date: 2022-09-28 03:22:27
Hi Jakub, On Tue, Sep 27, 2022 at 12:13:03PM +0800, Hangbin Liu wrote:
quoted hunk ↗ jump to hunk
@@ -3009,6 +3012,11 @@ static int do_setlink(const struct sk_buff *skb, } } + nskb = rtmsg_ifinfo_build_skb(RTM_NEWLINK, dev, 0, 0, GFP_KERNEL, NULL, + 0, pid, nlh->nlmsg_seq); + if (nskb) + rtnl_notify(nskb, dev_net(dev), pid, RTNLGRP_LINK, nlh, GFP_KERNEL);
BTW, in do_setlink() I planed to use RTM_SETLINK. But I found iproute2 use RTM_NEWLINK to set links. And I saw an old doc[1] said """ - RTM_SETLINK does not follow the usual rtnetlink conventions and ignores all netlink flags The RTM_NEWLINK message type is a superset of RTM_SETLINK, it allows to change both driver specific and generic attributes of the device. """ So I just use RTM_NEWLINK for the notification. Do you think if we should use RTM_SETLINK? [1] https://lwn.net/Articles/236919/ Thanks Hangbin