[PATCH rfc v2 05/10] net: dsa: qca8k: Drop replies with wrong sequence numbers
flat view
STALE1477d
From: Andrew Lunn <andrew@lunn.ch>
Date: 2022-09-22 17:59:00
Subsystem:
networking drivers, networking [dsa], qualcomm atheros qca8k dsa switch driver, the rest · Maintainers:
Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Andrew Lunn, Vladimir Oltean, Christian Marangi, Linus Torvalds
A response with the wrong sequence number is likely to be a late arriving responses, which the driver has already given up waiting for. Drop it rather than signalling the complete. If the complete was signalled, this late response could take the place of the genuine reply which is soon to follow. Signed-off-by: Andrew Lunn <andrew@lunn.ch> --- drivers/net/dsa/qca/qca8k-8xxx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/dsa/qca/qca8k-8xxx.c b/drivers/net/dsa/qca/qca8k-8xxx.c
index 2f92cabe21af..fdf27306d169 100644
--- a/drivers/net/dsa/qca/qca8k-8xxx.c
+++ b/drivers/net/dsa/qca/qca8k-8xxx.c@@ -145,9 +145,9 @@ static void qca8k_rw_reg_ack_handler(struct dsa_switch *ds, struct sk_buff *skb) cmd = FIELD_GET(QCA_HDR_MGMT_CMD, mgmt_ethhdr->command); len = FIELD_GET(QCA_HDR_MGMT_LENGTH, mgmt_ethhdr->command); - /* Make sure the seq match the requested packet */ + /* Make sure the seq match the requested packet. If not, drop. */ if (mgmt_ethhdr->seq == mgmt_eth_data->seq) - mgmt_eth_data->ack = true; + return; if (cmd == MDIO_READ) { mgmt_eth_data->data[0] = mgmt_ethhdr->mdio_data;
--
2.37.2